Skip to content

Ensure nightly pipelines are correctly detected in Canonical

Balasankar 'Balu' C requested to merge fix-nightly-in-canonical-rat into master

What does this MR do?

This MR does three things

  1. Ensure nightly pipelines are correctly detected in Canonical. Right now, the PROTECTED_TEST_PIPELINE rule gets evaluated before nightly ones. So, we move that rune to be further down in the list. (As a workaround, we are passing PIPELINE_TYPE in the schedules so that this computation doesn't come into play)
  2. Add the existing RAT and RAT:FIPS jobs for nightly pipelines too. They replace the RAT-Nightly and RAT-Nightly-FIPS jobs that existed in the dev.gitlab.org pipeline.
  3. Ensure tagging of QA image uses the correct image SHA from GitLab Rails pipelines. This was broken for EE pipelines because we were looking for gitlab-rails-ee component in version-manifest.json file while we only had gitlab-rails in there (since that is the component name).

Related issues

#8357

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Jason Plum

Merge request reports