Ensure nightly pipelines are correctly detected in Canonical
What does this MR do?
This MR does three things
- Ensure nightly pipelines are correctly detected in Canonical. Right now, the
PROTECTED_TEST_PIPELINErule gets evaluated before nightly ones. So, we move that rune to be further down in the list. (As a workaround, we are passingPIPELINE_TYPEin the schedules so that this computation doesn't come into play) - Add the existing RAT and RAT:FIPS jobs for nightly pipelines too. They replace the
RAT-NightlyandRAT-Nightly-FIPSjobs that existed in the dev.gitlab.org pipeline. - Ensure tagging of QA image uses the correct image SHA from GitLab Rails pipelines. This was broken for EE pipelines because we were looking for
gitlab-rails-eecomponent inversion-manifest.jsonfile while we only hadgitlab-railsin there (since that is the component name).
Related issues
#8357
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual Trigger:ee-packagejobs have a green pipeline running against latest commit. -
If config/softwareorconfig/patchesdirectories are changed, make sure thebuild-package-on-all-osjob within theTrigger:ee-packagedownstream pipeline succeeded. -
If you are changing anything SSL related, then the Trigger:package:fipsmanual job within theTrigger:ee-packagedownstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed to dev.gitlab.orgto confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. -
Tests added. -
Integration tests added to GitLab QA. -
Equivalent MR/issue for the GitLab Chart opened. -
Validate potential values for new configuration settings. Formats such as integer 10, duration10s, URIscheme://user:passwd@host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Jason Plum