Ensure nightly pipelines are correctly detected in Canonical

What does this MR do?

This MR does three things

1. Ensure nightly pipelines are correctly detected in Canonical. Right now, the PROTECTED_TEST_PIPELINE rule gets evaluated before nightly ones. So, we move that rune to be further down in the list. (As a workaround, we are passing PIPELINE_TYPE in the schedules so that this computation doesn't come into play)
2. Add the existing RAT and RAT:FIPS jobs for nightly pipelines too. They replace the RAT-Nightly and RAT-Nightly-FIPS jobs that existed in the dev.gitlab.org pipeline.
3. Ensure tagging of QA image uses the correct image SHA from GitLab Rails pipelines. This was broken for EE pipelines because we were looking for gitlab-rails-ee component in version-manifest.json file while we only had gitlab-rails in there (since that is the component name).

Related issues

#8357

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

• MR title and description are up to date, accurate, and descriptive.
• MR targeting the appropriate branch.
• Latest Merge Result pipeline is green.
• When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

• The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
• If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
• If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
• If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

• Test plan indicating conditions for success has been posted and passes.
• Documentation created/updated.
• Tests added.
• Integration tests added to GitLab QA.
• Equivalent MR/issue for the GitLab Chart opened.
• Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

changed milestone to %16.10

added devopssystems group::distributionbuild groupdistribution maintenancepipelines sectioncore platform typemaintenance labels

assigned to @balasankarc

1 Message

📖

Once your MR is ready for review you can comment @gitlab-bot ready <@user> to request the first review to someone. It's recommended that you pick the one suggested by the reviewer roulette. But you can ignore it and assign it to someone else if you see fit. Merge requests are handled according to the workflow documented in our handbook and should receive a response within the limit documented in our Service-level objective (SLO). If you don't receive a response from the reviewer within the SLO, please mention @gitlab-org/distribution, or one of our Project Maintainers

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Reviewer	Maintainer
@WarheadsSE (UTC-5, 10.5 hours behind @balasankarc)	@apatterson2 (UTC-7, 12.5 hours behind @balasankarc)

If needed, you can retry the 🔁 danger-review job that generated this comment.

Generated by 🚫 Danger

added 7 commits

• 541acc1f...e108dc7f - 4 commits from branch master
• 5e8235a2 - Ensure nightly pipelines are correctly detected in Canonical
• 3cdc5dc5 - Enable RAT and RAT:FIPS jobs in nightly pipelines in Canonical
• 1e9f8bca - Ensure facts generate gitlab-rails-ee file also

Compare with previous version

changed the description

E2E Test Result Summary

allure-report-publisher generated test report!

qa-subset-test: ❌ test report for 1e9f8bca

expand test summary

+---------------------------------------------------------------------+
|                           suites summary                            |
+----------------+--------+--------+---------+-------+-------+--------+
|                | passed | failed | skipped | flaky | total | result |
+----------------+--------+--------+---------+-------+-------+--------+
| Plan           | 171    | 0      | 1       | 0     | 172   | ✅     |
| Create         | 216    | 0      | 26      | 0     | 242   | ✅     |
| Verify         | 105    | 0      | 3       | 0     | 108   | ✅     |
| Govern         | 164    | 1      | 1       | 0     | 166   | ❌     |
| Systems        | 8      | 0      | 0       | 0     | 8     | ✅     |
| Monitor        | 33     | 0      | 1       | 0     | 34    | ✅     |
| GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
| Data Stores    | 97     | 0      | 0       | 0     | 97    | ✅     |
| Package        | 157    | 9      | 11      | 0     | 177   | ❌     |
| Manage         | 2      | 0      | 0       | 0     | 2     | ✅     |
| Release        | 15     | 0      | 0       | 0     | 15    | ✅     |
| Configure      | 1      | 0      | 0       | 0     | 1     | ✅     |
| Analytics      | 3      | 0      | 0       | 0     | 3     | ✅     |
+----------------+--------+--------+---------+-------+-------+--------+
| Total          | 974    | 10     | 44      | 0     | 1028  | ❌     |
+----------------+--------+--------+---------+-------+-------+--------+

@WarheadsSE Can you please take a look or pass on to someone else? Thanks.

requested review from @balasankarc

requested review from @WarheadsSE and removed review request for @balasankarc

marked the checklist item MR title and description are up to date, accurate, and descriptive. as completed

marked the checklist item When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow. as completed

marked the checklist item MR targeting the appropriate branch. as completed

marked the checklist item Latest Merge Result pipeline is green. as completed

marked the checklist item The manual Trigger:ee-package jobs have a green pipeline running against latest commit. as completed

marked the checklist item If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken. as completed

Dev pipeline, ✅ https://dev.gitlab.org/gitlab/omnibus-gitlab/-/pipelines/318369

approved this merge request

added workflowin review label

requested review from @apatterson2 and removed review request for @WarheadsSE