Allow setting custom gitlab config for Gitaly
Allow setting custom gitlab config for Gitaly
Administrators may now set `gitlab` configuration values
directly rather than rely on automatic calculations from
the rails service.
Related https://gitlab.com/gitlab-com/gl-infra/production-engineering/-/issues/24530
Changelog: added
What does this MR do?
Allow setting custom gitlab config for Gitaly
As solution for https://gitlab.com/gitlab-com/gl-infra/production-engineering/-/issues/24530, we made a change in gitlab-omnibus cookbook (gitlab-cookbooks/cookbook-omnibus-gitlab!121 (merged)) that only removes configuration for explicitly disabled services. Subsequently, we disabled the gitlab-rails
service in our Gitaly configuration, thinking that Gitaly doesn't depend on configurations from other services, which turned out to be wrong and caused an incident in staging (gitlab-com/gl-infra/production#17595 (closed)).
I believe there's no reason to disallow custom configuration for the gitlab
section of Gitaly's config.toml
. Allowing such custom configuration would allow us to disable the gitlab-rails
service from the Gitaly nodes and complete the objective of https://gitlab.com/gitlab-com/gl-infra/production-engineering/-/issues/24530.
Related issues
https://gitlab.com/gitlab-com/gl-infra/production-engineering/-/issues/24530
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual Trigger:ee-package
jobs have a green pipeline running against latest commit. -
If config/software
orconfig/patches
directories are changed, make sure thebuild-package-on-all-os
job within theTrigger:ee-package
downstream pipeline succeeded. -
If you are changing anything SSL related, then the Trigger:package:fips
manual job within theTrigger:ee-package
downstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed to dev.gitlab.org
to confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. -
Tests added. -
Integration tests added to GitLab QA. -
Equivalent MR/issue for the GitLab Chart opened. -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.