Skip to content

Add active directory + smart card settings to gitlab.yml

Andrew Evans requested to merge atevans/smartcard-ad-settings into master

What does this MR do?

Add active directory + smart card settings to gitlab.yml

An upcoming change in GitLab will introduce two new settings in the ldap: ➡ servers: subsections, to allow authenticating users via smart card against LDAP servers that are Active Directory based. The configuration is per-server-specific, so should be placed in the same configuration block as other LDAP settings.

This change exposes the new settings and adds defaults to omnibus. The smartcard_ad_cert_format setting should default to nil / off, and administrators must opt-in to the new behavior by configuring a value for it.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Andrew Evans

Merge request reports