Fix build order of git-filter-repo to fix unwanted rebuilds
Change git-filter-repo position in build order
When git-filter-repo is a dependency of gitaly, Omnibus will
place it early in the build order and, by necessity, git.
This behavior causes cache to bust frequently. This change
re-arranges the dependency order and keeps git builds
in the later stages.
Signed-off-by: Balasankar 'Balu' C <balasankar@gitlab.com>
What does this MR do?
Fix build order of git-filter-repo to fix unwanted rebuilds.
git-filter-repo is a dependency of Gitaly. But placing it there will cause it to be built early in the build list, which will in-turn cause git to be built early (Because omnibus will build leaf dependencies first, before top level dependencies). git, being built from gitaly source will bust cache often, and cause unnecessary rebuilds. Hence, we are placing git-filter-repo as a project dependency after git.
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual Trigger:ee-packagejobs have a green pipeline running against latest commit. -
If config/softwareorconfig/patchesdirectories are changed, make sure thebuild-package-on-all-osjob within theTrigger:ee-packagedownstream pipeline succeeded. -
If you are changing anything SSL related, then the Trigger:package:fipsmanual job within theTrigger:ee-packagedownstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed to dev.gitlab.orgto confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. -
Tests added. -
Integration tests added to GitLab QA. -
Equivalent MR/issue for the GitLab Chart opened. -
Validate potential values for new configuration settings. Formats such as integer 10, duration10s, URIscheme://user:passwd@host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Robert Marshall