Skip to content

Support external consul binary

Clemens Beck requested to merge 8285-support-external-consul into master

What does this MR do?

Support external consul binary

Allow users to bring their own consul, that is not bundled by Omnibus.
The binary path can be configured by setting
consul['binary_path'] = '/custom/consul'.

To customize the consul configuration use the known consul flags.

Consul Admin Documentation: https://docs.gitlab.com/ee/administration/consul.html

Changelog: added
Introduce gitlab-ctl command to download consul

Download a consul binary with `gitlab-ctl consul download`
which Omnibus can use instead of the bundled consul binary.

Changelog: added

Related issues

Closes #8285

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Hossein Pursultani

Merge request reports