Restart NGINX on version change
What does this MR do?
Restart NGINX on version change
Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/4837
Changelog: fixed
Related issues
Closes #4837 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual Trigger:ee-packagejobs have a green pipeline running against latest commit. -
Ifconfig/softwareorconfig/patchesdirectories are changed, make sure thebuild-package-on-all-osjob within theTrigger:ee-packagedownstream pipeline succeeded. -
If you are changing anything SSL related, then theTrigger:package:fipsmanual job within theTrigger:ee-packagedownstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed todev.gitlab.orgto confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. -
Tests added. -
Integration tests added to GitLab QA. -
Equivalent MR/issue for the GitLab Chart opened. -
Validate potential values for new configuration settings. Formats such as integer10, duration10s, URIscheme://user:passwd@host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Test Plan
-
Install a fresh release
-
Confirm the NGINX
VERSIONfile was created:> cat /var/opt/gitlab/nginx/VERSION nginx version: nginx/1.24.0 -
Mock a upgraded NGINX by modifying the
VERSIONfile:> echo "nginx version: nginx/1.23.0" > /var/opt/gitlab/nginx/VERSION -
Run
gitlab-ctl reconfigureand confirm NGINX is restarted:INFO: version_file[Create version file for NGINX] sending restart action to runit_service[nginx]
Edited by Clemens Beck