Skip to content

Update template for security-target label

Steve Abrams requested to merge delivery19680-security-target into master

What does this MR do?

We are moving to a new process for including security issues in planned security releases. See gitlab-com/gl-infra/delivery#19686 (closed) for full details on the new process.

This MR removes the step to manually link security implementation issues to the security release tracking issue. We instead add a step after the issue development is complete to add the security-target label so the issue can be automatically linked when ready.

We also apply the security-notifications issue to the template. This allows the issue to receive automatic comments when the new stable branch has been created, which unblocks the last backport to be created.

We will be going through any currently in progress issues to makes sure they get these updates.

Related issues

gitlab-com/gl-infra/delivery#19680 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Steve Abrams

Merge request reports