Skip to content

Add clean up steps in preparation for re2 v2.0 gem

Stan Hu requested to merge sh-prepare-re2-2 into master

What does this MR do?

As mentioned in https://ruby.social/@mudge/111029298058288514, re2 v2.0 will ship with precompiled native gems. In preparation for that, perform clean up on unnecessary files:

  1. As we do with nokogiri and gprc, remove unnecessary precompiled libraries for unused Ruby versions.

  2. For arm64 platforms where we recompile native gems from source, the ports directory holds the abseil-cpp and libre2 tarballs. The extracted source, headers, and compiled libraries are also stored there. These files are not necessary since the final shared library statically links with the libraries.

These changes are backwards compatible with re2 v1.0 since v1.0 doesn't ship with these files.

Related issues

re2 v2.0 will be used in gitlab!131273 (merged).

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Stan Hu

Merge request reports