Skip to content

Update builder to use nodejs 18.17.2

DJ Mountney requested to merge update-nodejs-version into master

What does this MR do?

Update Node.js to 18.17.1 as the part of our epic about updating Node.js version to 18 (LTS).

Jumping from builder version 1.21.1 to 1.24.0 - https://gitlab.com/gitlab-org/gitlab-omnibus-builder/-/tags

  • 1.22 Included the initial nodejs version bump
  • 1.23 Included the golang update that we already got backported to 1.21.1
  • 1.24 fixed some issues with the nodejs bump for SLES

Related issues

Update to node@18 across the codebase (&9477 - closed)

Update Node.js from 16 to 18 (gitlab-omnibus-builder#61 - closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by DJ Mountney

Merge request reports