Skip to content

Make AWS AMI builder fetch package from artifact instead of S3 bucket

Balasankar 'Balu' C requested to merge make-ami-use-artifact into master

What does this MR do?

Make AWS AMI builder fetch package from artifact instead of S3 bucket. Depends on !6973 (merged).

Because testing this locally (with CI_JOB_TOKEN) is difficult, to be on the safer side I have added an env variable switch that will help us use the old way of building it in case we see some breakage during the release. This involves maintaining two copies of the files, but given we can remove them once we see the release, I think it is an acceptable tradeoff.

Related issues

Closes: https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7840

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Andrew Patterson

Merge request reports