Skip to content

Bump libevent to 2.1.12

Robert Marshall requested to merge update-libevent-version into master

What does this MR do?

Bump libevent to 2.1.12

- Update libevent from 2.1.8 to 2.1.12

Related https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7839

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

Discovered problems building libevent while testing Add Debian 12 builder images (gitlab-omnibus-builder!288 - merged)

From the test build pipeline:

/usr/bin/ld: ./.libs/libevent.so: undefined reference to `arc4random_addrandom'
/usr/bin/ld: ./.libs/libevent_core.so: undefined reference to `arc4random_addrandom'
/usr/bin/ld: ./.libs/libevent.so: undefined reference to `arc4random_addrandom'

In the CHANGELOG from libevent version 2.1.9-beta:

Fix arc4random_addrandom() detecting and fallback (regression) (303d6d77g)

Verified that 2.1.9-beta resolves the build issues.

Executed a build with 2.1.12-stable and installed the Debian 12 package to validate it works.

The full 2.1.2-stable CHANGELOG.

Notable changes:

  • 2.1.11-stable
    • ABI breakage:
      • Protect min_heap_push_ against integer overflow. (8c899768 Tobias Stoeckmann)
      • Revert "Protect min_heap_push_ against integer overflow." (18104973 Azat Khuzhin)

This is the issue upstream that tracked the fix in 2.1.9-beta.

Related issues

Related #7839 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Robert Marshall

Merge request reports