Skip to content

Add settings to control secret generation and persistence

Balasankar 'Balu' C requested to merge 7700-control-secret-generation into master
Add secret generation control settings

- Adds option: package['generate_default_secrets'] = true
- Adds option: package['generate_secrets_json_file'] = true
- The options control whether or not secrets are generated and
  written to `JSON` by Omnibus during installation and reconfigure.
- Feature is not yet intended for usage in a self-managed instance

Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7700

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>

What does this MR do?

Add settings to control

  1. Whether default secrets be generated or not.
  2. Whether gitlab-secrets.json file be written or not.

Related issues

Closes #7700 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Robert Marshall

Merge request reports