Skip to content

Remove gitaly-ruby build

DJ Mountney requested to merge remove-gitaly-ruby-build into master

What does this MR do?

Remove gitaly-ruby build

  • No longer try to build gitaly-ruby, which is now an empty folder in gitaly

!6826 (merged) should be a further followup, to clean up the config that was assocated with gitaly-ruby

But this MR should be a quicker review to get the pipeline working again.

Related issues

Fixes #7760 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Test plan

  1. Confirm builds on all OS
  2. Confirm QA tests are passing - (gitaly working, we have removed a service directory, so we need to actually run gitlab and ensure omnibus/runit is all happy)
  3. Confirm final license output for gitaly looks valid
Edited by Robert Marshall

Merge request reports