Remove 'gitlab_default_can_create_group' setting

What does this MR do?

Remove rails 'default_can_create_group' setting

Remove the option gitlab-rails['default_can_create_group']
which was deprecated in 15.5.

Deprecation MR: https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/6316
Closes: https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7217

Changelog: removed

Related issues

Closes #7217 (closed)

Test plan

• Verify gitlab_default_can_create_group is not rendered anymore

  docker run --rm -d --name gitlab registry.gitlab.com/gitlab-org/omnibus-gitlab/gitlab-ee:15.10.3-rfbranch.840675919.82589d47-0`
  docker exec gitlab cat /opt/gitlab/embedded/service/gitlab-rails/config/gitlab.yml | yq '.production.gitlab | with_entries(select((.key == "default_can_create_group")))'
  {}

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

• Merge Request Title, and Description are up to date, accurate, and descriptive
• MR targeting the appropriate branch
• MR has a green pipeline on GitLab.com
• Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
• trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

• Test plan indicating conditions for success has been posted and passes
• Documentation created/updated
• Tests added
• Integration tests added to GitLab QA
• Equivalent MR/issue for the GitLab Chart opened
  • gitlab-org/charts/gitlab#3821 (closed)
  • gitlab-org/charts/gitlab!3105 (merged)

changed milestone to %16.0

added Deliverable Distribution KR1 Distribution OBJ1 FY24Q2 devopssystems groupdistribution group::distributiondeploy maintenanceremoval priority1 sectioncore platform typemaintenance workflowin dev labels

assigned to @clemensbeck

	1 Warning
	You've made some changes in the cookbooks, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding the typemaintenance label in that case.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed the description

marked the checklist item Merge Request Title, and Description are up to date, accurate, and descriptive as completed

marked the checklist item MR has a green pipeline on GitLab.com as completed

marked the checklist item MR targeting the appropriate branch as completed

marked the checklist item Equivalent MR/issue for the GitLab Chart opened as completed

mentioned in merge request gitlab-org/charts/gitlab!3105 (merged)

changed title from Draft: Remove rails 'default_can_create_group' setting to Draft: Remove 'gitlab_default_can_create_group' setting

changed the description

marked the checklist item Test plan indicating conditions for success has been posted and passes as completed

Opening this up for review as pipeline failure seems unrelated.

Progress on failing specs in tracked in https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/405137.

added workflowready for review label and removed workflowin dev label

marked this merge request as ready

requested review from @rmarshall

added workflowin review label and removed workflowready for review label

marked the checklist item Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks as completed

approved this merge request

QA packages did not complete; test failures do not look correct.

Downloaded package and installed locally to verify installation.

Confirmed the features are not present and I can interact with the GitLab instance normally:

• create group
• create issue
• pull/push to repository and make merge requests

Looks good, approving.

Thank you @clemensbeck

See Remove deprecation notice for gitlab_default_ca... (#7769 - closed) for final follow up.

merged

mentioned in commit b1efa25f

added workflowstaging-canary label and removed workflowin review label

mentioned in merge request !6755 (merged)

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added releasedcandidate label

mentioned in issue #7790 (closed)

added releasedpublished label and removed releasedcandidate label