Skip to content

Bundle libarchive in the package

Balasankar 'Balu' C requested to merge 7741-libarchive-liblzma-sles into master

What does this MR do?

If libarchive is present in system library locations and not bundled with omnibus-gitlab package, then Chef will incorrectly attempt to use it, and can potentially fail as seen from #7741 (closed). Hence, we need to bundle libarchive in the package.

Testing

  1. Deploy an openSUSE Leap 15.4 instance (you can use GCP for this, or Docker) and install libarchive13 package
  2. Install latest GitLab version and run reconfigure. See it fails with an error message similar to the following
    FATAL: LoadError: /opt/gitlab/embedded/lib/ruby/3.0.0/x86_64-linux/openssl.so: undefined symbol: EC_GROUP_new_curve_GF2m, version OPENSSL_1_1_0 - /opt/gitlab/embedded/lib/ruby/3.0.0/x86_64-linux/openssl.so
  3. Repeat the same with the package from this MR and see that the error does not pop up.

Related issues

Closes #7741 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Balasankar 'Balu' C

Merge request reports