Skip to content

Convert Strings to Integer in Praefect's fallback config logic

Sami Hiltunen requested to merge smh-accept-string-integers into master

What does this MR do?

Praefect's old configuration template automatically converted Strings to Integers. While we've documented that the integer options should be configured as Integer, the Strings have been accepted in the past as well. This became apparent as GitLab Environment Toolkit is configuring the database port as a string rather than an integer. While the issues is likely not widespread due to the documentation configuring the relevant keys as actual integers, let's handle this case to ensure the past config keeps working if this has been done.

GET has already been updated to render the database ports as strings so this change aims to mostly keep backwards compatibility with past versions of GET.

Related issues

Failing GET job: https://gitlab.com/gitlab-org/quality/gitlab-environment-toolkit-configs/quality/-/jobs/3798055299#L2668

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Hossein Pursultani

Merge request reports