Skip to content

Adds presigned URL output for GCS sync

John Jarvis requested to merge jarv/sync-presigned into master

What does this MR do?

This adds pre-signed URL output for the packages we sync to GCS. We are changing the behavior to sync all omnibus packages built on tags and branches to GCS, so we can eventually deprecate the AWS bucket sync for https://gitlab.com/gitlab-org/security/omnibus-gitlab/-/issues/3.

  • Moves most of the logic to a helper so we now have proper tests for it
  • Deprecates the gitlab-com-pkgs bucket, replacing it with gitlab-com-pkgs-release and gitlab-com-pkgs-builds bucket for tagged and non-tagged builds. These buckets are already created so we can start using them after this is merged.

pipeline on dev for testing https://dev.gitlab.org/gitlab/omnibus-gitlab/-/pipelines/273417

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by John Jarvis

Merge request reports