Skip to content

Ensure runit is started before gitlab-sshd

Robert Marshall requested to merge ensure-runit-started-before-gitlab-sshd into master

What does this MR do?

Ensure runit is started before gitlab-sshd

- If doing a fresh installation with gitlab-sshd enabled, the cookbook
  hangs waiting for the service to start. This happens because runit is
  not yet configured and running when the gitlab-shell recipe executes.
  This changes the gitlab-shell recipe to happen after the runit recipe
  so that the gitlab-sshd service can start up correctly if enabled at
  first installation.

Related https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/5937

Changelog: fixed

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

Related issues

Related #5937 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened

Merge request reports