Skip to content

Mark praefect configuration as sensitive

Steve Xuereb requested to merge feat/praefect-config-sensitive into master

What does this MR do?

Mark praefect configuration as sensitive

What

Mark the praefect configuration as sensitive

Why

Stop showing the diff in the chef-client run logs since the Praefect configuration has database passwords inside of it, and logging these tokens can be easily leaked if we copy/paste the logs or if we store these logs externally.

Related issues

Reference: https://gitlab.com/gitlab-com/gl-infra/reliability/-/issues/17171

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Steve Xuereb

Merge request reports