Skip to content

Migrate gitlab-pages service to underscored form in Chef attributes

Balasankar 'Balu' C requested to merge move-pages-to-underscored-form into master 
Deprecate node['gitlab-pages'] in favor of node['gitlab_pages']

Use `node['gitlab_pages']` to access settings instead of
`node['gitlab-pages']`

Changelog: deprecated

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>

What does this MR do?

Replace the usage of node['gitlab-pages'] with node['gitlab_pages'] as mentioned in #6873 (closed). Other components will follow.

Depends on !6614 (merged)

Related issues

Closes #7412 (closed) under #6873 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Robert Marshall

Merge request reports