Skip to content

Consolidate hyphenation and underscoring of keys to methods

Balasankar 'Balu' C requested to merge move-hyphenation-of-keys-to-a-method into master

What does this MR do?

Currently, we hyphenate first level keys when used as node attributes. However, because gitlab.rb uses an underscored form of these keys, it becomes confusing to figure out which form to use where. So, we are moving to underscored form everywhere.

As a first step, we are consolidating the hyphenation and underscroring logic that is spread across the codebase into dedicated methods so that we can migrate services one at a time using an exception list.

Related issues

#6873 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Robert Marshall

Merge request reports