Skip to content

Raise an error when initial root password is too short

Dustin Collins requested to merge 6779-fail-on-too-short-root-password into master

What does this MR do?

Raises an error during Chef run when the value of ['gitlab_rails']['initial_root_password'] is to short. This lets the user know there is a problem as soon as possible.

Related issues

Closes #6779 (closed)

Testing

Download latest deb created by this MR and install it on a Ubuntu 22.04 VM with this configuration. The configuration should fail with an error message about the password being too short.

gitlab_rails['initial_root_password'] = 'test'

Change the password to be one of >=8 characters, like 'test1234' and run gitlab-ctl reconfigure. This run should complete without error.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened

Closes #6779 (closed)

Edited by Robert Marshall

Merge request reports