Skip to content

Ensure specs run fine with Ruby 3

Balasankar 'Balu' C requested to merge run-specs-with-ruby3 into master

What does this MR do?

Handle the positional argument change that was made mandatory in Ruby 3

Make rspec tests Ruby 3 compatible

- Updates positional arguments in rspec tests
  that changed in the Ruby 3 major version update

Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>

Testing

$ docker run -it ruby:3.0 bash
$ git clone https://gitlab.com/gitlab-org/omnibus-gitlab.git -b "run-specs-with-ruby3"
$ cd omnibus-gitlab
$ bundle install
$ bundle exec rspec spec/lib

Related issues

&5149 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Robert Marshall

Merge request reports