Skip to content

Bump Consul version to 1.12.5

Balasankar 'Balu' C requested to merge 7213-bump-consul-1.12 into master

What does this MR do?

Bump Consul version to 1.12.5 to support Go 1.18.

Notes

  1. TLS configuration has been enhanced to support per-endpoint settings. Hence, the global configuration been moved from top level of the configuration hash to tls.default (along with tls.http and tls.grpc) stanzas. While we can move this in the backend quite easily, because we didn't expose all the TLS settings via gitlab.rb, there is a possibility of users setting this directly via consul['configuration'] and not using the dedicated settings in gitlab.rb. So, I think we should be handling this for them.
  2. Another deprecation/renaming is of acl.tokens.master and acl.tokens.agent_master settings, which have been renamed to acl.tokens.initial_management and acl.tokens.agent_recovery.

Testing

Note: While testing multi-node systems, verify if functionality works when multiple Consul servers are on different versions

  1. TLS functionality
    • Fresh installations
    • Upgrades
  2. Fresh single node installations
    • Service Discovery
  3. Single node installations upgrade
    • Shows warning to restart Consul
    • Service Discovery still works
  4. Fresh installation - PG HA - Covered by gitlab-org/quality/quality-engineering/team-tasks#1489 (closed)
    • Patroni failover still works
  5. PG HA upgrades - Covered by gitlab-org/quality/quality-engineering/team-tasks#1489 (closed)
    • Patroni failover still works
  6. Fresh installation - Geo - Covered by gitlab-org/quality/quality-engineering/team-tasks#1493 (closed)
    • Promote DB works
  7. Geo upgrades - Covered by gitlab-org/quality/quality-engineering/team-tasks#1493 (closed)
    • Promote DB works

Related issues

Closes #7213 (closed)

Related to &8843 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Robert Marshall

Merge request reports

Loading