Skip to content

Extend and enhance SELinux distro support

Robert Marshall requested to merge 7219-detect-generalize-selinux-supported-distro-check into master

What does this MR do?

Extend and enhance SELinux distro support

- Rename RedhatHelper to SELinuxDistroHelper
- Explicitly support AmazonLinux 2 while avoiding accidentaly support
  for Enterprise Linux 2
- Use selinux_supported? as the single method to simplify checks in code
  rather than adding more and more boolean expressions
- Add rspec test coverage for SELinuxDistroHelper
- Fix boolean logic when checking Enterprise Linux versions 7 and 8
  where instead of a boolean, an integer was being returned

Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7219

Changelog: fixed

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

Related issues

Closes #7219 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened

Merge request reports