Skip to content

Allow output of Rails migrations in reconfigure step

Stan Hu requested to merge sh-allow-stdout-migration-failures into master

What does this MR do?

!5971 (merged) disabled output of steps in stderr/stdout to avoid leaking passwords. This change also applied to suppressing the output of Rails migrations, which can fail due to a variety of reasons. This made it harder to debug upgrade failures.

gitlab-rake db:migrate should not leak any sensitive information, as it is usually just prints out the status of the migrations and error messages if one fails. This commit re-enables the output to ease debugging.

By default, Chef's bash resource prints out the environment variables upon failure, but the environment may contain sensitive information. Add a custom resource (bash_hide_env) that suppresses the environment output.

Related issues

Relates to #6801 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Robert Marshall

Merge request reports