Skip to content

Praefect: Deprecate DB metrics configuration

Justin Tobler requested to merge jt-deprecate-db-metrics-config into master

What does this MR do?

The prometheus_exclude_database_from_default_metrics configuration is used to determine whether Praefect DB metrics are exported on the default /metrics endpoint or on a separate /db_metrics endpoint. Since scraping DB metrics requires expensive queries this configuration is defaulted to true enabling separate configuration of scraping intervals. In GitLab v15.5 this configuration is deprecated and in v16.0 removed. This change updates the deprecations list for this configuration.

Related issues

#7072 (closed)

Deprecation schedule

Configuration Key Deprecation Date Removal Date
prometheus_exclude_database_from_default_metrics 15.5 16.0

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on the dev.gitlab.org mirror for this branch if the change is touching anything besides documentation or internal cookbooks. Please note that feature branches are not automatically mirrored to dev.gitlab.org, and should be manually pushed whenever necessary.
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests updated
  • Equivalent MR/issue for the GitLab Chart opened
  • Notify Product for inclusion in release notes
Edited by Justin Tobler

Merge request reports