Skip to content

Create new helper for consul watch methods

Robert Marshall requested to merge 6562-extract-consul-watcher-methods-to-separate-helper into master

What does this MR do?

Create new helper for consul watch methods

- The consul watch methods are not related to the general operation of
  consul and it is confusing to maintain those in the consul helper
  alongside TLS configuration and API information. This extracts them
  to a separate method for easier maintenance and extension.

Related https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/6562

Changelog: changed

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

Related issues

Related #6562 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Hossein Pursultani

Merge request reports