Remove svlogd filter from consul configuration

What does this MR do?

This MR removes the svlogd filter that we added in !1946 (merged) as it is no longer matching the log line, and is no longer necessary to suppress repeated log entries.

Background

The Consul v1.7.0 release (Changelog link) included two pull requests that changed how this logging was handled

• GH-5739 changed how successive check logged critical errors to the consul log output and removed the warning log line reported in #6589 (closed)
• GH-7130 overhauled the logging across the board and changed the format of the service check from agent: Check 'service:postgresql' is now critical to agent: Check is now critical: check=service:postgresql

We upgraded consul to 1.9.6 from 1.6.10 in GitLab 14 : Update consul to version 1.9.6 (!5344 - merged)

Change Rationale

This MR removes the "logging_filter" functionality entirely. The rationale behind that is that we do not provide a mechanism for adding filters to the svlogd config for any other runit/svlogd-managed service in Omnibus, and removing it reduces the configuration overhead. We also don't list it as a setting in the gitlab.rb.template

It's possible that a GitLab Omnibus user has made use of this logging_filter for their own needs, though incredibly unlikely. If that's the case, we could add this functionality back with just an empty hash as the default and add a test as appropriate.

Related issues

Closes Consul logs a warning on standby postgresql nod... (#6589 - closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

• Merge Request Title, and Description are up to date, accurate, and descriptive
• MR targeting the appropriate branch
• MR has a green pipeline on GitLab.com
• Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
• trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

• Test plan indicating conditions for success has been posted and passes
• Documentation created/updated
• Tests added
• Integration tests added to GitLab QA
• Equivalent MR/issue for the GitLab Chart opened