Skip to content

[Object storage] Set direct_upload=true and background_upload=false

What does this MR do?

In gitlab-com/gl-infra&734 (closed), we are attempting to remove background upload. The deprecation message was sent out for a while. To ensure that the deprecation was safe and gradual, we break the whole process into multiple iterations:

  • Set direct_upload=true and background_upload=false in omnibus
  • Remove those configurations completely
  • Remove the code paths related to background_upload

This MR is to set the default configuration of background_upload to false and direct_upload to true. This MR touches the configurations of each component only. If the consolidated object storage configuration is set, background_upload is disabled by default. Also, some components, such as pages, ci_secure_files, and terraform_states don't support neither direct_upload nor background_upload.

Related issues

Closes gitlab-com/gl-infra/scalability#1688 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened

Merge request reports