Skip to content

Always disable proxy_intercept_errors for kas

Mikhail Mazurskiy requested to merge ash2k/no_proxy_intercept_errors into master

What does this MR do?

Disables custom error page functionality for kas proxy locations. These locations are API locations, never visible to a human. They should not be returning custom content on errors but the original response to aid debugging.

Related issues

I was checking connection timeouts for gitlab-org/cluster-integration/gitlab-agent#231 (closed), but didn't find anything suspicious, just this tweak for error handling.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Mikhail Mazurskiy

Merge request reports