Skip to content

Build package-scripts after components have been built

Balasankar 'Balu' C requested to merge move-package-scripts-closer-to-rails into master

What does this MR do?

package-scripts version is tied either to the git tag or to the latest stable tag. Due to this, in auto-deploy pipelines it always dirties the cache, causing few other GitLab components to be rebuilt.

package-scripts being built again unnecessarily because some other GitLab component dirtied the cache is definitely better than N other GitLab components being rebuilt because package-scripts dirtied the cache. package-scripts build steps are trivial to have any impact.

Hence, package-scripts has been moved to the end of the build chain, just before version manifest file.

From #5990 (comment 685694368)

Related issues

#5990

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Robert Marshall

Merge request reports