Skip to content

add option for mTLS in Pages

feistel requested to merge feistel/omnibus-gitlab:feat/pages-mtls into master

What does this MR do?

Add an option to add client certificates to Pages to support mTLS when talking to the GitLab API.

Note: client-cert-key-pairs is a MultiStringFlag (with , as a separator) and just like listen-http it can be declared multiple times and have multiple values.

Related issues

See gitlab-pages#548
See gitlab-pages!663 (closed)
Docs: gitlab!79159 (merged)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Brian Williams

Merge request reports