Skip to content

Return early from trusted certificate handling if hashing/symlinking failed

Balasankar 'Balu' C requested to merge 6569-do-not-proceed-if-symlinking-or-rehashing-certs-failed into master

What does this MR do?

Return early from trusted certificate handling if hashing/symlinking failed so that we don't end wrong information to trusted hash file, and inform users that trusted certificate handling failed.

Testing

  1. Install GitLab and run reconfigure
  2. Note the content of /var/opt/gitlab/trusted-certs-directory-hash
  3. Move /opt/gitlab/embedded/bin/c_rehash to /opt/gitlab/embedded/bin/c_rehash.bak
  4. Add certificates to /etc/gitlab/trusted-certs.
  5. Run reconfigure.
  6. See the warning at the end of the reconfigure.
  7. Ensure that content of /var/opt/gitlab/trusted-certs-directory-hash hasn't changed (thus fixing #6570 (closed))

Related issues

Closes #6569 (closed) #6570 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Balasankar 'Balu' C

Merge request reports