Skip to content

Drop --without-gnutls flag from curl

Stan Hu requested to merge sh-drop-gnutls-curl-flag into master

What does this MR do?

https://github.com/curl/curl/commit/68d89f242cf9f6326e3b2f6fe119b7c74ef41c66 dropped the use of --without-gnutls in favor of --with-* options. This commit actually had the opposite effect of enabling GnuTLS when --without-gnutls were set. https://github.com/curl/curl/pull/7994 fixes this behavior.

We can drop this now that this does completely the opposite of what it is supposed to be doing.

Discovered in !5592 (comment 731305703)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Robert Marshall

Merge request reports