Refactor Danger job for software definitions

Robert Marshallrequested to merge
refactor-danger-job-for-software-definitions into master

What does this MR do?

The Danger job for software definitions had inverted logic such that it only triggered if the merge request was labeled as tooling.

This refactor does the following:

  • Rename array of labels that indicate an engineer tagged a merge request as not changing any actual software builds
  • Remove labels from label array that are not actually used to indicate no changes are happening in a software definition build
  • Change name of calculated boolean variable to be clearer on when the Danger job should or should not emit a message

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened

Merge request reports