Add support for gitlab['omniauth_cas3_session_duration']

Brennen Bearnesrequested to merge
brennenpike/omnibus-gitlab:cas3-session-duration into master

What does this MR do?

For background, I'm attempting to configure CAS session lifetime on our instance (at 13.12.9) to something other than the default of 8 days. See T288757 - Increase GitLab session lifetime to something reasonable on the Wikimedia Phabricator.

As far as I can tell, Omnibus GitLab doesn't presently support setting omniauth.cas3.session_duration from gitlab.rb, unlike the example gitlab.yml.

I'm submitting these changes per Changing gitlab.yml and application.yml settings.

Haven't touched any tests as I couldn't quite figure out where would be appropriate. Something in spec/chef/recipes/gitlab-rails/gitlab_yml/omniauth_spec.rb?

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Brennen Bearnes

Merge request reports