Refactor Gitlab Config and Gitlab Cluster configs
What does this MR do?
- Rename and refactor SettingsHelper into SettingsDSL
- Because SettingsHelper was renamed, I fixed rubocop cop violations that were ignored before
- GitlabCluster attributes are merged all at the same time as
node.override
, not overGitlab[]
- GitlabCluster is now a singleton, so no need to instantiate and keep multiple references of it everywhere
- GitlabCluster most used public API become
GitlabCluster.config.{get,set,save,all}
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened
Edited by Gabriel Mazetto