Skip to content

Reduce pg-upgrade space needed calculation from 2x to 1x current usage

Justin Farmiloe requested to merge jfarmiloe-modify-space-needed-calc into master

What does this MR do?

Amends the gitlab-ctl pg-upgrade disk space check to require room for just one copy of the database rather than two.

Anomaly identified by customer in ZD internal who pointed out current calculation applies test of (2 * current-db-used-space) < (0.9 * available-space) which is twice the space required to store one additional copy of the database as created by the pg_upgrade utility.

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Justin Farmiloe

Merge request reports