Skip terraform_state in preinst backup
What does this MR do?
GitLab Backup rake has added a new type called
terraform_state
which does not need capturing
as part of pre-install safety backup (DB only).
This change adds terraform_state
to the existing
SKIP list in the preinstall template.
Testing (manual):
Since preinst runs before the new package files are
installed, and new package is the one that includes
support for type terraform_states
, a concern
could be that the SKIP value of terraform_states
could go unrecognized and throw an error.
I verified for this manually and found that the backup rake task will not raise an error for a SKIP argument value it does not yet recognize.
Regression test case for this scenario has been added via gitlab!63347 (merged)
Related issues
Related issue: gitlab#331806 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened