Deprecate configuring Gitaly nodes in virtual storage's config root
What does this MR do?
Historically, a virtual storage's Gitaly nodes have been configured root of the virtual storage's config object. This didn't work well, as the configuration format did not match the structure Praefect itself was using and made it awkward to add virtual storage scoped configuration keys. Since then, we've modified the configuration format in Omnibus to also put the nodes under the 'nodes' key and included fallback code to retain backwards compatibility. In 15.0, we have the chance to remove the fallback code. To prepare for that, this commit adds logs a deprecation message if the there are some nodes configured in the root of the virtual storage's config rather than under the 'nodes' key.
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened