gitlab-redis-cli: fix authentication with unquoted values
What does this MR do?
During gitlab-com/gl-infra/production#3417 (closed) we discovered a format change in the omnibus-generated /var/opt/gitlab/redis/redis.conf
file.
Previously, it would generate a quoted value, like:
requirepass "secret123"
But now it generates an unquoted value like so:
requirepass secret123
This patch fixes the gitlab-redis-cli
cli utility to support the unquoted format as well. I tested against both formats.
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened