Skip to content

Avoid to install package_cloud in the jobs not to upload packages

Takuya Noguchi requested to merge install-package_cloud-only-in-deploy-jobs into master

What does this MR do?

Avoids to install package_cloud gem in the jobs not to upload packages. That was originally introduced in !307 (merged) in 2015-03 (6 years ago) and has been untouched to date.

Note: as the jobs to upload packages from CI environment to packagecloud.io are limited to jobs on dev.gitlab.org, testing these changes in the CI pipeline at dev.gitlab.org is required in the review process.

This also improves logs of Trigger:ce-package/Trigger:ee-package jobs of our CI by removing the following warning message:

./builds/gitlab-org/omnibus-gitlab/gems/ruby/2.7.0/gems/json_pure-1.8.1/lib/json/common.rb:155: warning: Using the last argument as keyword parameters is deprecated

cf. https://gitlab.com/gitlab-org/omnibus-gitlab/-/jobs/952848314

Related issues

n/a

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Takuya Noguchi

Merge request reports