Skip to content

Update gitlab-styles from 4.3.0 to 5.4.0

Takuya Noguchi requested to merge gitlab-styles-5.4.0 into master

What does this MR do?

Updates gitlab-styles from 4.3.0 to 5.4.0. All cops which become offending the rules are disabled by updating .rubocop_todo.yml automatically with rubocop --auto-gen-config.

While internally upgrading rubocop from 0.82.0 to 0.89.1 through gitlab-styles, our custom cop was migrated to v1 API. Ref. rubocop-hq/rubocop#7868 and https://docs.rubocop.org/rubocop/v1_upgrade_notes.html#cop-upgrade-guide

Bumping two major version-update (6.0.0) was avoided.

Related issues

Previous update: !4703 (merged) (2.8.0 to 4.3.0)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Takuya Noguchi

Merge request reports