Remove `git_process` metrics probes
What does this MR do?
Implements:
gitlab#290765 (closed) from
&5035
probe_git
method is implemented in GitProcessProber
(https://gitlab.com/gitlab-org/gitlab-exporter/-/blob/master/lib/gitlab_exporter/git.rb#L93), which, in turn, uses regular ProcessProber
(https://gitlab.com/gitlab-org/gitlab-exporter/-/blob/master/lib/gitlab_exporter/git.rb#L108).
ProcessProber
produces metrics with process_*
prefix (https://gitlab.com/gitlab-org/gitlab-exporter/-/blob/master/lib/gitlab_exporter/process.rb#L73), and it was discussed in gitlab#290765 (closed), that it should be safe to remove them.
According to what Matthias found (gitlab#290765 (comment 461467963)), the only git-related thing could be git_upload_pack
, which was discussed to be safe for removal (gitlab#290765 (comment 468990598)).
In general, all Git-related metrics are expected to be exported by Gitaly for consistency.
GitProber
(https://gitlab.com/gitlab-org/gitlab-exporter/-/blob/master/lib/gitlab_exporter/git.rb#L64), such as git_pull_time_milliseconds
, we remove only what is produced by GitProcessProber
.
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened