Ensure logrotate is on by default for gitaly/*.log
What does this MR do?
While working on gitlab-com/gl-infra/scalability#519 (closed) I noticed that the default logrotate config in Omnibus ignores /var/log/gitlab/gitaly/*.log
even though Gitaly writes some non-Runit logs there. (gitaly!2678 (merged) adds a new log file to that directory.)
This change adds gitaly to the default logrotate services.
Related issues
gitlab-com/gl-infra/scalability#519 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion
Required
-
Merge Request Title, and Description are up to date, accurate, and descriptive -
MR targeting the appropriate branch -
MR has a green pipeline on GitLab.com -
Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks -
trigger-package
has a green pipeline running against latest commit
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes -
Documentation created/updated -
Tests added -
Integration tests added to GitLab QA -
Equivalent MR/issue for the GitLab Chart opened
I am not 100% sure how logs are handled in CNG but I can see that the default application logs go to a file and that script is written so that it works correctly if there is more than one log file. So adding one more log file to Gitaly in CNG should not break anything.