Resolve "Migrations can silently fail during deployments"

What does this MR do?

On package upgrade, exit non-zero if there is an error during the reconfigure step.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

• Merge Request Title, and Description are up to date, accurate, and descriptive
• MR targeting the appropriate branch
• MR has a green pipeline on GitLab.com
• Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
• trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

• Test plan indicating conditions for success has been posted and passes
• Documentation created/updated This should be reinstating expected behavior.
• Tests added Bug was due to a change in behavior of a third party library.
• Integration tests added to GitLab QA Issue is in the upgrade process
• Equivalent MR/issue for the GitLab Chart opened Only applies to omnibus-gitlab

Closes #5610 (closed)