Skip to content

Improve pgbouncer running? method

Robert Marshall requested to merge improve-pgbouncer-running-check into master

What does this MR do?

PGBouncer does not always correctly identify the difference between running and running plus able to listen. This merge request changes the running? method to properly identify when PGBouncer is actually ready to avoid corner cases where the service is running but not listening. This was discovered while trying to implement configurations for the 2K user reference architecture in Orchestrator.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for the GitLab Chart opened
Edited by Ian Baum

Merge request reports