Skip to content

Remove stub_status => on from nginx status on gitlab.rb config file

Kelvin Jasperson requested to merge zxjinn/omnibus-gitlab:zxjinn-master-patch-80410 into master

What does this MR do?

There are three status sites- /nginx_status, /metrics, and /rails-metrics.

The stub_status param only needs to be turned on for /nginx_status which it's hardcoded to be enabled on in the chef template (see nginx-status template for 13.2 stable)

This MR deletes the suggestion to have stub_status on; for the sites that's don't need it, which will let prometheus /metrics (via vts) function properly, and /rails-metrics (via proxy pass to the workhorse) function properly.

When stub_status on; is present for the other two paths, only nginx stub status information is returned, and no prometheus metrics or rails-metrics are returned.

Related issues

Checklist

See Definition of done.

  • Changelog entry created. Not applicable for Documentation changes and minor changes. -- done
  • Documentation created/updated -- (documentation already reflects this change on docs.gitlab.com)
  • Tests added -- (N/A)
  • Integration tests added to GitLab QA, if applicable -- (N/A)
  • MR targeting master branch
  • MR has a green pipeline on GitLab.com
  • Equivalent MR/issue for CNG opened if applicable
  • trigger-package has a green pipeline running against latest commit

Reviewer Checklist

In addition to above, reviewer must:

  • Pipeline is green on dev.gitlab.org if the change is not touching documentation or internal cookbooks
Edited by Kelvin Jasperson

Merge request reports