Adding Vacuum Queue metrics to postgres-exporter.yaml

added devopssystems groupdistribution labels

added Community contribution label

added 1st contribution label

@twk3 can you help with the review or assign to another reviewer?

mentioned in issue gitlab-com/gl-infra/production#1426 (closed)

assigned to @twk3

@emanuel_ongres can you enable shared runners on your fork, so we can have the tests run?

assigned to @emanuel_ongres

added database label

added devopsmonitor + 1 deleted label and removed devopssystems groupdistribution labels

@Finotto can you please provide review for the query?

assigned to @Finotto

resolved all threads

unassigned @emanuel_ongres

@twk3 I reviewed the query, it is good.

unassigned @Finotto

	2 Warnings
	You may want to add groupdistribution label to this MR for gitlab-insights
	You’ve made some changes in the cookbooks, but didn’t add any tests. That’s OK as long as you’re refactoring existing code, but please consider adding the ~backstage label in that case.

1 Message

Available reviewers

The following people are available to review this merge request. If this is a high priority merge request, and no maintainers from the Distribution team are available, please check with one of Emergency maintainers

Name	GitLab Handle	Role
`@balasankarc`	Balasankar ‘Balu’ C	Maintainer
`@ibaum`	Ian Baum	Maintainer
`@twk3`	David ‘DJ’ Mountney	Maintainer
`@brodock`	Gabriel Mazetto	Emergency maintainer
`@marin`	Marin Jankovski	Emergency maintainer

Generated by Danger

added typefeature label

@emanuel_ongres can you please add a changelog?

In the meantime I am testing the change in an omnibus build, then will hand over to someone from the monitor team for final approval.

changed milestone to %12.6

assigned to @emanuel_ongres

unassigned @twk3

@mnohr can you have someone from your team review/approve this change? They can assign it back to me for merge once complete.

assigned to @mnohr

added 1 commit

d64d672b - Added changelog for the postgres_exporter metric Vacuum Queue addition

Compare with previous version

resolved all threads

added 1 commit

873a55d9 - Update postgres-queries.yaml

Compare with previous version

mentioned in issue #4887 (closed)

unassigned @emanuel_ongres

assigned to @dwilkins

@emanuel_ongres Thanks for your contribution! I made a couple of suggestions above for your consideration. I wanted to go ahead and get these to you since I think they're pretty straightforward. I'm continuing to do some deeper testing, but it might take a little time.

Also, that's an impressive statement - it's a little challenging to spin it up on a dev environment and get some vacuums to kick off. My initial attempt included changing the where clause to ensure that postgres-exporter actually got some rows back from the query.

I'm having a couple of issues with Grafana including the new pg_vacuum_queue_* metrics in it's type-ahead suggestions. Prometheus includes them in the type-ahead suggestions and I suspect that this difference has something to do with blank values for some columns in the queries. To be fair, I think those blank columns are due to my changes to the where clause. I'll let you know as soon as I know something definitive.

@emanuel_ongres I've completed my checks - sorry for the delay. Just a few suggestions on naming and column types. Several of existing postgres-exporter queries return gauge columns that are NULL, so that doesn't seem to be a problem.

This will be a great addition to the metrics!

unassigned @dwilkins

assigned to @emanuel_ongres and @twk3 and unassigned @mnohr

added 1 commit

1876a53e - Adding feedback fixes

Compare with previous version

changed milestone to %12.7

added missed:12.6 label

assigned to @dwilkins

@dwilkins we decided to rewrite this query entirely, as we've had inherited this from previous monitoring tools. All your inputs are completely valuable, so I'm going to rewrite this down to make it more readable and agnostic.

unassigned @dwilkins

added 1 commit

6a0ce0b6 - Done updates to the postgres-queries.yaml

Compare with previous version

added 1 commit

a8872f8b - Fixed the query and output postgres-queries.yaml

Compare with previous version

assigned to @dwilkins

changed milestone to %12.8

added missed:12.7 label

mentioned in issue gitlab-com/gl-infra/production#1587 (closed)

@twk3 the query and metric definition look good to me . My only concern is that it might not return metrics for tables in the gitabhq_* database due to the setting in /opt/gitlab/etc/postgres-exporter/env/DATA_SOURCE_NAME.